Fix System.Configuration.ConfigurationManager.Tests on Android and reenable on non-Windows platforms #56558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable on non-Windows platforms The test assembly got changed to `$(NetCoreAppCurrent)-windows` in dotnet@809a06f#diff-4d639cb37fe53cdeae4262c1f5be7936cdd81e3b4f256f9c59ad02ec69b300d9R7 but when talking to Viktor we're not sure why, probably a mistake. Target `$(NetCoreAppCurrent)` instead so it runs on all platforms and fix a test issue that occurs on Android due to BaseDirectory not having a trailing slash. Fixes dotnet#37071 Incidentally, that's likely also the reason why the .csproj set `TestDisableAppDomain` so we can remove that as well. Also replace `TestDisableParallelization` with the assembly attribute equivalent which is what we use everywhere else.
|
Tagging subscribers to this area: @safern Issue DetailsThe test assembly got changed to Target Also replace
|
steveisok
approved these changes
Jul 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test assembly got changed to
$(NetCoreAppCurrent)-windowsin 809a06f#diff-4d639cb37fe53cdeae4262c1f5be7936cdd81e3b4f256f9c59ad02ec69b300d9R7 but when talking to Viktor we're not sure why, probably a mistake.Target
$(NetCoreAppCurrent)instead so it runs on all platforms and fix a test issue that occurs on Android due to BaseDirectory not having a trailing slash.Fixes #37071
Incidentally, that's likely also the reason why the .csproj set
TestDisableAppDomainso we can remove that as well.Also replace
TestDisableParallelizationwith the assembly attribute equivalent which is what we use everywhere else.