Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Console.Write on iOS #56713

Merged
merged 33 commits into from
Sep 2, 2021
Merged

Fix Console.Write on iOS #56713

merged 33 commits into from
Sep 2, 2021

Commits on Aug 2, 2021

  1. Fix Console.Write on iOS

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    71b3888 View commit details
    Browse the repository at this point in the history

  2. Move the helper method to iOS-specific location

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    8f6f7bc View commit details
    Browse the repository at this point in the history

  3. Add a test

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    a97f0d5 View commit details
    Browse the repository at this point in the history

  4. Remove unused using

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    90bf33c View commit details
    Browse the repository at this point in the history

  5. Apply Ralf's suggestion

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e6806e4 View commit details
    Browse the repository at this point in the history

  6. Move Interop.Sys.Log to a local function

    @MaximLipnin
    MaximLipnin committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    2bdb6e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    612dc1c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    6f8542b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Move the caching logic over to StreamWriter

    @MaximLipnin
    MaximLipnin committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    47d8f01 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    4f0653a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    14545a8 View commit details
    Browse the repository at this point in the history

  2. feedback

    @MaximLipnin
    MaximLipnin committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    725e64c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Remove unused usings

    @MaximLipnin
    MaximLipnin committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5b8499c View commit details
    Browse the repository at this point in the history

  2. Derive from StreamWriter

    @MaximLipnin
    MaximLipnin committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    61bb68b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    68e10e7 View commit details
    Browse the repository at this point in the history

  4. Feedback

    @MaximLipnin
    MaximLipnin committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    ac45868 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    2e57d54 View commit details
    Browse the repository at this point in the history

  2. Try a solution not changing public API surface and using NSLogStream … 

    …with a decoder
    @MaximLipnin
    MaximLipnin committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    c8aa30f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Some feedback

    @MaximLipnin
    MaximLipnin committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b76ddfe View commit details
    Browse the repository at this point in the history

  2. Use ArrayPool

    @MaximLipnin
    MaximLipnin committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b999fff View commit details
    Browse the repository at this point in the history

  3. Not rely on the length of the rented array

    @MaximLipnin
    MaximLipnin committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    49f5c41 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    aaa1f35 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Address the feedback

    @MaximLipnin
    MaximLipnin committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    90da2a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    88685c7 View commit details
    Browse the repository at this point in the history

  3. not use _ prefix for local variable 

    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @MaximLipnin @adamsitnik
    MaximLipnin and adamsitnik authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    976954b View commit details
    Browse the repository at this point in the history

  4. Address the feedback

    @MaximLipnin
    MaximLipnin committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    245edb3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix_console_write_on_ios' of https://github.com/maximli… 

    …pnin/runtime into fix_console_write_on_ios

# Conflicts:
#	src/libraries/System.Console/src/System/ConsolePal.iOS.cs
    @MaximLipnin
    MaximLipnin committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a234df5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Fix an error

    @MaximLipnin
    MaximLipnin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    34d215f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_console_write_on_ios

    @MaximLipnin
    MaximLipnin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    1eb7528 View commit details
    Browse the repository at this point in the history

  3. Print a span rather than a string

    @MaximLipnin
    MaximLipnin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    a2e118e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Slice the char span to the exact used length

    @MaximLipnin
    MaximLipnin committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    732a62f View commit details
    Browse the repository at this point in the history

  2. Address Stephen's feedback

    @MaximLipnin
    MaximLipnin committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9375848 View commit details
    Browse the repository at this point in the history

  3. Remove a redundant using

    @MaximLipnin
    MaximLipnin committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    7504d30 View commit details
    Browse the repository at this point in the history