Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpStress build #56912

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

antonfirsov
Copy link
Member

#56775 broke HttpStress.

Instead of including System.Net.Security, I'm reverting this to the old stringly-typed code, so it keeps building with official preview SDK-s, not only docker / locally-built one.

@ghost
Copy link

ghost commented Aug 5, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

#56775 broke HttpStress.

Instead of including System.Net.Security, I'm reverting this to the old stringly-typed code, so it keeps building with official preview SDK-s, not only docker / locally-built one.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov requested a review from a team August 5, 2021 15:10
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably eventually work but looks ok for now.

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@antonfirsov

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov merged commit 6f19f67 into dotnet:main Aug 6, 2021
@antonfirsov
Copy link
Member Author

This will probably eventually work but looks ok for now.

@wfurt you mean eventually this will stop working? If yes why?

@wfurt
Copy link
Member

wfurt commented Aug 6, 2021

No, this will always work. SslApplicationProtocol.Http3 will work once it bubbles up & down through SDKs and updates.

@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants