Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caching ConsoleStream for both iOS and Android #58967

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

steveisok
Copy link
Member

Expands on #56713 by moving the caching implementation to a separate internal class and leaving only the interop calls in ConsolePal.iOS and ConsolePal.Android.

Fixes #57304

Expands on dotnet#56713 by moving the caching implementation to a separate internal class leaving only the interop calls in ConsolePal.iOS and ConsolePal.Android

Fixes dotnet#57304
@ghost
Copy link

ghost commented Sep 10, 2021

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Expands on #56713 by moving the caching implementation to a separate internal class and leaving only the interop calls in ConsolePal.iOS and ConsolePal.Android.

Fixes #57304

Author: steveisok
Assignees: -
Labels:

area-System.Console

Milestone: -

@steveisok
Copy link
Member Author

Failures are unrelated. Timing out most likely due to https://github.com/dotnet/core-eng/issues/14346

@steveisok steveisok merged commit edeb905 into dotnet:main Sep 14, 2021
@steveisok
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1233898126

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android + Console.WriteLine + format strings = possible unexpected extra newlines
3 participants