Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested static attribute support. #61508

Closed

Conversation

ilonatommy
Copy link
Member

This PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.

ilonatommy and others added 22 commits November 5, 2021 11:57
…chance it will be located out of the current assembly.
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 12, 2021
@ilonatommy ilonatommy self-assigned this Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

ilonatommy and others added 22 commits November 18, 2021 09:35
…er.cs

Co-authored-by: Larry Ewing <lewing@microsoft.com>
…n-tests

Nested static classes fix broken tests
…tion

Fix for 4 failing tests of Count evaluation.
@ilonatommy
Copy link
Member Author

To be merged after #61660

@ilonatommy ilonatommy marked this pull request as ready for review November 19, 2021 12:57
@ilonatommy ilonatommy removed the request for review from marek-safar November 19, 2021 12:57
@ilonatommy
Copy link
Member Author

Closing, as it will get merged into fix-static-attribute-support instead of main.

@ilonatommy ilonatommy closed this Nov 24, 2021
@ilonatommy ilonatommy deleted the add-nested-static-attribute-support branch November 24, 2021 09:04
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants