-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested static attribute support. #61508
Closed
ilonatommy
wants to merge
79
commits into
dotnet:main
from
ilonatommy:add-nested-static-attribute-support
Closed
Add nested static attribute support. #61508
ilonatommy
wants to merge
79
commits into
dotnet:main
from
ilonatommy:add-nested-static-attribute-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…natommy/runtime into add-static-attribute-support
…ts that fail in Consol App.
…chance it will be located out of the current assembly.
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.
|
35 tasks
…ed static classes).
…com/ilonatommy/runtime into add-nested-static-attribute-support
…ub.com/ilonatommy/runtime into nested-static-classes-fix-broken-tests
…er.cs Co-authored-by: Larry Ewing <lewing@microsoft.com>
…-classes-fix-broken-tests
…n-tests Nested static classes fix broken tests
…tion Fix for 4 failing tests of Count evaluation.
To be merged after #61660 |
Closing, as it will get merged into fix-static-attribute-support instead of main. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.