Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ActivityContext.TryParse overload #63692

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add ActivityContext.TryParse overload #63692

merged 1 commit into from
Jan 13, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 12, 2022 •
edited
Loading

Fixes #42575

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tarekgh Jan 12, 2022
@ghost
Copy link

ghost commented Jan 12, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tarekgh
Assignees: tarekgh
Labels:

new-api-needs-documentation, area-System.Diagnostics.Activity
Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Jan 12, 2022

CC @CodeBlanch @cijothomas @reyang @noahfalk

@tarekgh tarekgh added this to the 7.0.0 milestone Jan 12, 2022
@tarekgh tarekgh requested a review from noahfalk January 12, 2022 18:27
reyang
reyang approved these changes Jan 12, 2022
View reviewed changes
Copy link

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

noahfalk
noahfalk approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CodeBlanch
CodeBlanch approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh tarekgh merged commit 93c6134 into dotnet:main Jan 13, 2022
@tarekgh tarekgh deleted the AddActivityContext.ParseOverload branch January 13, 2022 01:02
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@reyang reyang reyang approved these changes

@noahfalk noahfalk noahfalk approved these changes

@cijothomas cijothomas cijothomas approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Activity new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

ActivityContext.TryParse should support IsRemote
6 participants
@tarekgh @stephentoub @cijothomas @noahfalk @reyang @CodeBlanch