Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ToTimeoutSeconds.SendPingAsync and fix TimeSpan behavior #67253

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

deeprobin
Copy link
Contributor

As described in #64860 (comment), this reverts the SendPingAsync overloads and further code review suggestions applied.

Follow-up for #64860 - Closes #14336

/cc @danmoseley
/cc @stephentoub

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 28, 2022
@ghost
Copy link

ghost commented Mar 28, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

As described in #64860 (comment), this reverts the SendPingAsync overloads and further code review suggestions applied.

Follow-up for #64860 - Closes #14336

/cc @danmoseley
/cc @stephentoub

Author: deeprobin
Assignees: -
Labels:

area-System.Net, new-api-needs-documentation

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@danmoseley
Copy link
Member

Thanks could you please open a new issue specifically to implement the async Ping API? That will involve someone going into the ping implementation so it should be separate from #67156

@deeprobin
Copy link
Contributor Author

Thanks could you please open a new issue specifically to implement the async Ping API? That will involve someone going into the ping implementation so it should be separate from #67156

#67260

@stephentoub stephentoub merged commit e81e77a into dotnet:main Mar 29, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use TimeSpan everywhere we use an int for seconds, milliseconds, and timeouts
4 participants