From 749dcc6266be4b4bb6cc424f837549de044425a2 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 29 Aug 2022 22:26:31 +0000 Subject: [PATCH 1/2] CI: Fix helix test results reporting PR #73060 broke uploading of helix test results. This was caused by the change: ```xml @(HelixPostCommand) ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes https://github.com/dotnet/runtime/issues/74699 . --- src/libraries/sendtohelixhelp.proj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index f7fadf8a6323f..6fc601db985d6 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -172,8 +172,8 @@ - @(HelixPreCommand) - @(HelixPostCommand) + $(HelixPreCommands);@(HelixPreCommand) + $(HelixPostCommands);@(HelixPostCommand) $(HelixCommandPrefix) @(HelixCommandPrefixItem -> 'set "%(Identity)"', ' & ') $(HelixCommandPrefix) @(HelixCommandPrefixItem, ' ') true From 4987c0a82e54f1da012fd419ac10b47c003f1928 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Tue, 30 Aug 2022 10:29:06 +0200 Subject: [PATCH 2/2] Disable failing tests, see https://github.com/dotnet/runtime/issues/74781 --- .../System.Numerics.Vectors/tests/GenericVectorTests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs index f4d2904a75361..3d095d04b6452 100644 --- a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs +++ b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs @@ -848,6 +848,7 @@ public void VectorSingleEqualsNaNTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/74781", TestRuntimes.Mono)] public void VectorDoubleEqualsNonCanonicalNaNTest() { // max 8 bit exponent, just under half max mantissa @@ -872,6 +873,7 @@ public void VectorDoubleEqualsNonCanonicalNaNTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/74781", TestRuntimes.Mono)] public void VectorSingleEqualsNonCanonicalNaNTest() { // max 11 bit exponent, just under half max mantissa