fix lower heap hard limit condition for regions #76407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsFixes #76199, where containers < 512mb were failing with E_OOM during GC initialization, since the check for
|
mangod9
commented
Sep 29, 2022
|
with the latest change, the lowest hard_limit possible is |
Maoni0
reviewed
Oct 3, 2022
Maoni0
reviewed
Oct 3, 2022
Maoni0
reviewed
Oct 3, 2022
Maoni0
approved these changes
Oct 3, 2022
|
The Hardware Instrinsics failure looks related to: #76280. Other PRs are failing with that same failure. Need to port to 7 hence merging. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3179565569 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76199, where containers < 512mb were failing with E_OOM during GC initialization, since the check for
region_size * heaps * 19 (various generations) < reservation sizewas failing.The logic is to now dynamically adjust region_size for smaller heap sizes. So for very small heap_hard_limits the region_size would be 1mb (instead of the default 4mb currently)