Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeSnippets tests more pluggable #76479

Merged

Conversation

jkoritzinsky
Copy link
Member

Make our CodeSnippets structure more pluggable by using an interface with static abstracts for common method types so future generators like the COM source generator can easily implement good test coverage without needing to rewrite all of the snippets from scratch.

Split out from #68276

…a solid contract to simplify authoring our custom type marshalling tests
@ghost
Copy link

ghost commented Oct 1, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Make our CodeSnippets structure more pluggable by using an interface with static abstracts for common method types so future generators like the COM source generator can easily implement good test coverage without needing to rewrite all of the snippets from scratch.

Split out from #68276

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@jkoritzinsky jkoritzinsky merged commit 22b04df into dotnet:main Oct 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2022
@jkoritzinsky jkoritzinsky deleted the refactored-generator-test-harness branch March 22, 2024 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants