Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Avoid unnecessarily zipping tests #76580

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

radical
Copy link
Member

@radical radical commented Oct 4, 2022

ZipTestArchive gets called twice, once for wasm build, and for wasm nested publish.

This saves about ~8mins on a full library tests build.

`ZipTestArchive` gets called twice, once for wasm build, and for wasm
nested publish.

This saves about ~8mins on a full library tests build.
@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Oct 4, 2022
@ghost
Copy link

ghost commented Oct 4, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

ZipTestArchive gets called twice, once for wasm build, and for wasm nested publish.

This saves about ~8mins on a full library tests build.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@ghost ghost assigned radical Oct 4, 2022
@radical
Copy link
Member Author

radical commented Oct 4, 2022

Coreclr runtime tests failure is #76280 .

@radical radical merged commit c075692 into dotnet:main Oct 4, 2022
@radical radical deleted the zip-tests branch October 4, 2022 04:08
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants