[wasm][debugger] Revert don't need to escape special characters anymore #78320
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsIf is a letter or a digit we don't need to escape which is the case of the swedish characters reported in #76777
|
|
Manual testing I've done - everything is OK:
|
|
Added the test case that will be executed on linux and here the screenshot to show it working correctly when debugging on chrome on Mac
|
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Can we use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))] here?
There was a problem hiding this comment.
or [PlatformSpecific(TestPlatforms.AnyUnix)]
There was a problem hiding this comment.
It looks like it doesn't work, it's trying to run it on windows:
[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)]
| [2022-11-24T14:57:59] DevToolsProxy-0 Debug: sending error response for id: msg-:::5 -> [Result: IsOk: False, IsErr: True, Value: , Error: {
| "message": "Assembly 'debugger-test-with-colon-in-source-name.dll' not found,needed to get method location of 'DebuggerTests.CheckColonInSourceName:Evaluate'"
| } ]
There was a problem hiding this comment.
Same error with this option:
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
There was a problem hiding this comment.
Right: it looks like this one will work: [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux))]
| private static string EscapeAscii(string path) | ||
| { | ||
| var builder = new StringBuilder(); | ||
| foreach (var part in Regex.Split(path, @"([:/])")) |
There was a problem hiding this comment.
The : is needed only for windows. And for !windows, we can do a regular string split on /.
If we must use regex here, then maybe move it to a static readonly field.
src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
If is a letter or a digit we don't need to escape which is the case of the swedish characters reported in #76777