-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add warning code to all warnings produced in WasmAppBuilder #78755
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Fixes #78690
|
@radical Should I add warning code even for this one?
|
Good question. Remove the |
@akoeplinger @steveisok do we need to document these new warning codes anywhere? |
Yes but I think we also need to localize them if they're actually user-facing. I don't know if there's guidance/restrictions around coming up with new codes though. |
I have opened #79173 for following up on the localization, and documentation. |
The MacCatalyst failure is unrelated, and was - #78778 . |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3622382639 |
WASM0001
- All PInvoke related warningsWASM0002
- Missing CultureName metadata for satellite assemblyWASM0003
- Found identical vfs mappings for target pathWASM0004
- Loading assembly reference '..' for '..' failedFixes #78690