[Android] Fix SslStream on Android API 21-23 #78918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones |
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
am11
reviewed
Nov 28, 2022
src/native/libs/System.Security.Cryptography.Native.Android/pal_sslstream.c
Outdated
Show resolved
Hide resolved
am11
reviewed
Nov 28, 2022
src/native/libs/System.Security.Cryptography.Native.Android/pal_sslstream.c
Outdated
Show resolved
Hide resolved
5 tasks
simonrozsival
force-pushed
the
fix-android-ssl-legacy-apis
branch
3 times, most recently
from
8a82616 to
2b81a23
Compare
Code improvements
simonrozsival
force-pushed
the
fix-android-ssl-legacy-apis
branch
from
2b81a23 to
ec54d10
Compare
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
Dec 5, 2022
grendello
approved these changes
Dec 5, 2022
|
The failing tests are unrelated to this PR. |
simonrozsival
added a commit
to simonrozsival/runtime
that referenced
this pull request
Dec 6, 2022
simonrozsival
added a commit
to simonrozsival/runtime
that referenced
this pull request
Dec 6, 2022
carlossanlop
pushed a commit
that referenced
this pull request
Jan 4, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSLEngine in Android APIs 21-23 doesn't give us a way to enable SNI directly but it's possible to achieve by calling a method that isn't in the standard Java API. This workaround isn't very clean but it gets the job done. We can drop it as soon as we drop support for these API levels.
Closes #78715