-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Move AT_EXECFN to fallback for /proc/self/exe #79057
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #78958 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #78958 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 7.0.x
Approved by Tactics for 7.0.3. |
Backport of #78958 to release/7.0
/cc @janvorli @am11
Customer Impact
When building a self-contained console application targeting .NET 7, the console application doesn't work with shebang in Linux. This causes powershell v7.3.0 to stop working with shebang on Linux.
When building the same console application targeting .NET 6, the produced console application works fine with shebang.
Testing
CI coreclr and libraries tests
Risk
Low, the change just swaps the order of means we use for getting the current executable path, the
/proc/self/exe
is used first now. And in 6.0, we accidentally were using just the/proc/self/exe
for some time, so it was well tested.