Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CEEInfo::getAddressOfPInvokeTarget to handle already resolved P/Invokes #82150

Merged
merged 8 commits into from
Feb 15, 2023
Merged

Update CEEInfo::getAddressOfPInvokeTarget to handle already resolved P/Invokes #82150

merged 8 commits into from
Feb 15, 2023

Conversation

tannergooding
Copy link
Member

This resolves #82133 by taking advantage of already resolved P/Invokes and allows avoiding the indirection that otherwise exists.

@ghost ghost assigned tannergooding Feb 15, 2023
jkotas
jkotas reviewed Feb 15, 2023
View reviewed changes
@tannergooding tannergooding marked this pull request as ready for review February 15, 2023 13:43
@tannergooding
Copy link
Member Author

I had copied the suggested getAddressOfPInvokeTarget before the edit of CONTRACTL to use THROWS and GC_TRIGGERS. Fixed that and expecting CI to pass this time around.

This was referenced Feb 15, 2023
Closed
Closed
@tannergooding tannergooding merged commit 05f8388 into dotnet:main Feb 15, 2023
@tannergooding tannergooding deleted the pinvoke branch February 15, 2023 18:06
@tannergooding tannergooding mentioned this pull request Feb 15, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@tannergooding tannergooding

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support P/Invokes not going through a pre-stub in Tier 1
3 participants
@tannergooding @jkoritzinsky @jkotas