From 47d69ae234a7880f61cf088b0d350464065289ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Wed, 14 Jun 2023 09:21:16 +0900 Subject: [PATCH] Testing CI --- .../TypeSystem/Common/SignatureVariable.cs | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs b/src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs index b3184284f675bd..82d4ca3555d084 100644 --- a/src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs +++ b/src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs @@ -66,7 +66,16 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask) flags |= TypeFlags.SignatureTypeVariable; } - flags |= TypeFlags.AttributeCacheComputed; + // ****************************************************** + // Do not add other flags here. If you're hitting asserts + // because a flag wasn't set, this is a bug in the + // calling code. The fix is not here. + // + // The calling code is asking questions that are not + // possible to answer for signature variables + // (like: is this ByRef-like? We won't know until + // a substitution happens. Any answer would be wrong.) + // ****************************************************** return flags; } @@ -105,6 +114,17 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask) flags |= TypeFlags.SignatureMethodVariable; } + // ****************************************************** + // Do not add other flags here. If you're hitting asserts + // because a flag wasn't set, this is a bug in the + // calling code. The fix is not here. + // + // The calling code is asking questions that are not + // possible to answer for signature variables + // (like: is this ByRef-like? We won't know until + // a substitution happens. Any answer would be wrong.) + // ****************************************************** + return flags; }