From b19c7fd50d6c37952749ceb7a65c4e740e7960b2 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 18 Jul 2023 11:25:58 -0400 Subject: [PATCH] [wasm] Perf - update to track a regression in bdn argument parsing Passing arguments to bdn as `"--wasmArgs=--expose_wasm --module"` broke with the latest update. Now this gets incorrectly parsed. Instead, what works is: `--wasmArgs "--expose_wasm --module"`. --- eng/testing/performance/performance-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/testing/performance/performance-setup.sh b/eng/testing/performance/performance-setup.sh index 599096d54f098..0314580ab8953 100755 --- a/eng/testing/performance/performance-setup.sh +++ b/eng/testing/performance/performance-setup.sh @@ -410,7 +410,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then fi # Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line - extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine \\\"--wasmArgs=$wasm_args \\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data" + extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data" if [[ "$wasmaot" == "true" ]]; then extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600" fi