Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] Add telemetry for mobile and wasm workloads #90208

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

steveisok
Copy link
Member

@steveisok steveisok commented Aug 9, 2023

This change adds CLI telemetry for common mobile and wasm scenarios.

Total app size is another element we plan on tracking and that will be added in a follow up.

Fixes #88844

This change adds CLI telemetry for common mobile and wasm scenarios.
<_WorkloadUsesBlazorWasm>$(UsingMicrosoftNETSdkBlazorWebAssembly)</_WorkloadUsesBlazorWasm>
<_WorkloadUsesWasmSDK>$(UsingMicrosoftNETSdkWebAssembly)</_WorkloadUsesWasmSDK>
<_WorkloadUsesMonoAOT>$(RunAOTCompilation)</_WorkloadUsesMonoAOT>
<_WorkloadUsesMonoAOT Condition="'$(RunAOTCompilation)' == '' and '$(PublishAot)' != 'true' and ('$(TargetPlatformIdentifier)' == 'maccatalyst' or '$(TargetPlatformIdentifier)' == 'ios' or '$(TargetPlatformIdentifier)' == 'tvos')">$(_RunAotCompiler)</_WorkloadUsesMonoAOT>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we should do in the workloads in xamarin-macios instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but I would prefer if we track this all in one place.

</PropertyGroup>

<PropertyGroup>
<_WorkloadUsesAvalonia Condition="'$([System.IO.Path]::GetFileName(%(ReferencePath.Identity)).ToLower())' == 'avalonia.dll'">true</_WorkloadUsesAvalonia>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would checking the PackageReference work too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an avalonia ios sample, it'll have Avalonia.iOS as the PackageReference. I think it's simpler to use the referencepath since there's a consistent avalonia.dll.

@SamMonoRT
Copy link
Member

cc @ilonatommy @mkhamoyan - this adds a way to track telemetry for opt-in features - includes HybridGlobalization as well

@ivanpovazan
Copy link
Member

ivanpovazan commented Aug 10, 2023

@steveisok should we link this issue: #88844 ?

@SamMonoRT
Copy link
Member

SamMonoRT commented Aug 11, 2023

LGTM - is there any way of testing end-to-end short of merging and running queries?

(Irrespective - this is great, and we should merge it !)

@steveisok
Copy link
Member Author

LGTM - is there any way of testing end-to-end short of merging and running queries?

The WBT should be testing this out when they publish.

@steveisok steveisok merged commit b02e5e1 into dotnet:main Aug 12, 2023
21 checks passed
@steveisok steveisok deleted the workload-telemetry branch August 12, 2023 01:49
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NativeAOT] Add appropriate telemetry flags to track use of NativeAOT on iOS-like platforms
7 participants