-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workloads] Add telemetry for mobile and wasm workloads #90208
Conversation
This change adds CLI telemetry for common mobile and wasm scenarios.
src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadTelemetry.targets
Outdated
Show resolved
Hide resolved
<_WorkloadUsesBlazorWasm>$(UsingMicrosoftNETSdkBlazorWebAssembly)</_WorkloadUsesBlazorWasm> | ||
<_WorkloadUsesWasmSDK>$(UsingMicrosoftNETSdkWebAssembly)</_WorkloadUsesWasmSDK> | ||
<_WorkloadUsesMonoAOT>$(RunAOTCompilation)</_WorkloadUsesMonoAOT> | ||
<_WorkloadUsesMonoAOT Condition="'$(RunAOTCompilation)' == '' and '$(PublishAot)' != 'true' and ('$(TargetPlatformIdentifier)' == 'maccatalyst' or '$(TargetPlatformIdentifier)' == 'ios' or '$(TargetPlatformIdentifier)' == 'tvos')">$(_RunAotCompiler)</_WorkloadUsesMonoAOT> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we should do in the workloads in xamarin-macios instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but I would prefer if we track this all in one place.
src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadTelemetry.targets
Outdated
Show resolved
Hide resolved
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<_WorkloadUsesAvalonia Condition="'$([System.IO.Path]::GetFileName(%(ReferencePath.Identity)).ToLower())' == 'avalonia.dll'">true</_WorkloadUsesAvalonia> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would checking the PackageReference work too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an avalonia ios sample, it'll have Avalonia.iOS as the PackageReference. I think it's simpler to use the referencepath since there's a consistent avalonia.dll.
cc @ilonatommy @mkhamoyan - this adds a way to track telemetry for opt-in features - includes HybridGlobalization as well |
@steveisok should we link this issue: #88844 ? |
LGTM - is there any way of testing end-to-end short of merging and running queries? (Irrespective - this is great, and we should merge it !) |
The WBT should be testing this out when they publish. |
This change adds CLI telemetry for common mobile and wasm scenarios.
Total app size is another element we plan on tracking and that will be added in a follow up.
Fixes #88844