Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Add a dependency on dotnet/installer to get the latest #90904

Merged
merged 3 commits into from
Aug 24, 2023
Merged

[wasm] Add a dependency on dotnet/installer to get the latest #90904

merged 3 commits into from
Aug 24, 2023

Conversation

radical
Copy link
Member

@radical radical commented Aug 21, 2023

.. version, and use that for testing the workloads.

@radical radical added the arch-wasm WebAssembly architecture label Aug 21, 2023
@ghost ghost assigned radical Aug 21, 2023
@ghost
Copy link

ghost commented Aug 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. version, and use that for testing the workloads.

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 22, 2023
Open
@radical radical closed this Aug 22, 2023
@radical radical reopened this Aug 22, 2023
@radical
Copy link
Member Author

radical commented Aug 22, 2023 •
edited
Loading

Waiting on #90558 .

@radical radical closed this Aug 23, 2023
@radical radical reopened this Aug 23, 2023
@radical
[wasm] Add a dependency on dotnet/installer to get the latest
bcbe874 
.. version, and use that for testing the workloads.
@radical radical marked this pull request as ready for review August 23, 2023 05:00
maraf
maraf approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@radical radical merged commit c821c36 into dotnet:main Aug 24, 2023
178 of 181 checks passed
@radical radical deleted the add-installer-dep branch August 24, 2023 19:47
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@kg kg Awaiting requested review from kg

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @maraf