Fix fgOptimizeAddition opt for AOT #94350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes #94332 Thanks @MichalStrehovsky for finding the root cause, indeed, a Morph optimization folded "CNS1 + CNS2" where it wasn't legal
|
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet/jit-contrib PTAL, no diffs but fixes the AOT issue. I assume this will need to be backported to .NET 8.0 |
This was referenced Nov 3, 2023
jakobbotsch
approved these changes
Nov 6, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6773318364 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94332
Thanks @MichalStrehovsky for finding the root cause, indeed, a Morph optimization folded "CNS1 + CNS2" where it wasn't legal.
gtFoldExprConstcares about such cases so I am just forwarding the folding to that.