Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Do not throw in AssemblyExtensions.TryGetRawMetadata. #96370

Merged
merged 3 commits into from
Feb 17, 2024
Merged

[mono] Do not throw in AssemblyExtensions.TryGetRawMetadata. #96370

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4301a0
[mono] Do not throw in AssemblyExtensions.TryGetRawMetadata.
teo-tsirpanis Dec 30, 2023
e243bdc
Add a test for `AssemblyExtensions.TryGetRawMetadata`.
teo-tsirpanis Feb 11, 2024
a990b23
Try to read the assembly metadata blob in the test.
teo-tsirpanis Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/mono/System.Private.CoreLib/src/System/Reflection/Metadata/AssemblyExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ namespace System.Reflection.Metadata
public static class AssemblyExtensions
{
[CLSCompliant(false)]
public static unsafe bool TryGetRawMetadata(this Assembly assembly, out byte* blob, out int length) => throw new NotImplementedException();
public static unsafe bool TryGetRawMetadata(this Assembly assembly, out byte* blob, out int length)
{
ArgumentNullException.ThrowIfNull(assembly);

blob = null;
length = 0;
return false;
}
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
}
}