-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] - CancellationToken for JSWebWorker #96696
Merged
pavelsavara
merged 9 commits into
dotnet:main
from
pavelsavara:browser_worker_cancellation
Jan 11, 2024
Merged
[browser][MT] - CancellationToken for JSWebWorker #96696
pavelsavara
merged 9 commits into
dotnet:main
from
pavelsavara:browser_worker_cancellation
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix `UninstallWebWorkerInterop` for `JSWebWorker` when exception - `ReleasePromiseHolder` operations order - tests: `Executor_Cancellation`, `Executor_Propagates`
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
labels
Jan 9, 2024
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jan 9, 2024
...ervices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSSynchronizationContext.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jan 9, 2024
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jan 9, 2024
....InteropServices.JavaScript.UnitTests/System.Runtime.InteropServices.JavaScript.Tests.csproj
Outdated
Show resolved
Hide resolved
This was referenced Jan 9, 2024
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jan 10, 2024
...ervices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSSynchronizationContext.cs
Show resolved
Hide resolved
kg
reviewed
Jan 10, 2024
...ervices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSSynchronizationContext.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jan 10, 2024
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jan 10, 2024
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Show resolved
Hide resolved
kg
reviewed
Jan 10, 2024
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Outdated
Show resolved
Hide resolved
kg
approved these changes
Jan 10, 2024
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
I filled #96840, all other CI issues are well known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CancellationToken
forJSWebWorker
&JSSynchronizationContext
JSWebWorkerInstance<T>
as helperInstallWebWorkerInterop
andUninstallWebWorkerInterop
ScheduleJSPump
&_ScheduleJSPump
UninstallWebWorkerInterop
forJSWebWorker
when exceptionReleasePromiseHolder
operations orderExecutor_Cancellation
,Executor_Propagates
,JSDelay_Cancellation
,JSSynchronizationContext_Send_Post_Items_Cancellation
,JSSynchronizationContext_Send_Post_To_Canceled
,JSWebWorker_Abandon_Running
,JSWebWorker_Abandon_Running_JS
System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.ManagedDelay_ContinueWith
#96493