-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more ServicePoint properties #97537
Implement more ServicePoint properties #97537
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
Maybe I can implement the PlaintextStreamFilter = (context, ct) =>
{
ServicePoint.IdleSince = DateTime.Now;
return ValueTask.FromResult(context.PlaintextStream);
} But not sure if this is a good idea, any suggestions @dotnet/ncl ? |
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs
Outdated
Show resolved
Hide resolved
…t.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs
Outdated
Show resolved
Hide resolved
…se.cs Co-authored-by: Anton Firszov <antonfir@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple questions + style changes, otherwise this looks good
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
This reverts commit 7aa734f.
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
CI failures unrelated |
This PR implements:
HttpWebRequest:
ServicePoint:
ServicePoint but no effect (We're creating a new handler for every request if we have non-null
ServicePoint
):These properties will matter in case we want to invest some work in caching of
HttpClient
underHttpWebRequest
, the current implementation is straightforward and these properties are not gaining any advantage from it.