Commits on Feb 28, 2024

1. Fix unwound stack range check for the new EH …

   With the old EH, the unwound stack range limits are using SP for each
   frame on x64 and a caller SP on arm64, arm, riscv64 and longsoon.
   The ExceptionTracker::IsInStackRegionUnwoundBySpecifiedException takes
   that into consideration when detecting whether a frame with a specific
   SP was already unwound or not.
   With the new EH though, the range is always based on the actual SP of
   the frame, so the check was being done incorrectly on non-x64
   architectures.
   That lead to a crash in a test that has dynamic method code on stack
   and its frame was unwound. The bug has caused that method to not to be
   reported to GC, so the dynamic method was destroyed by GC. And later on,
   another GC stack walk has crashed while trying to get info on the
   method.
   This change fixes it by making the check with new EH enabled the same
   for all architectures, the same as it was for x64 in the old EH.
   
   Close dotnet#98914

   

   janvorli committed Feb 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for bf64021
   • Browse repository at this point

   Copy the full SHA

   bf64021 View commit details

   Browse the repository at this point in the history