Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or document Unsafe.AsPointer uses in core libraries #99146

Merged
merged 14 commits into from
Mar 5, 2024

Fix compile errors :)

c4433e8
Select commit
Loading
Failed to load commit list.
Merged

Remove or document Unsafe.AsPointer uses in core libraries #99146

Fix compile errors :)
c4433e8
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime (Build browser-wasm linux Release Mono_DebuggerTests_chrome) failed Mar 4, 2024 in 8m 12s

Build browser-wasm linux Release Mono_DebuggerTests_chrome failed

Annotations

Check failure on line 560 in src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release Mono_DebuggerTests_chrome)

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.cs#L560

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.Threading.cs(560,63): error CS8604: (NETCORE_ENGINEERING_TELEMETRY=Build) Possible null reference argument for parameter 'o' in 'nint EventSource.ObjectIDForEvents(object o)'.

Check failure on line 1127 in src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release Mono_DebuggerTests_chrome)

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs#L1127

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1127,28): error CS0214: (NETCORE_ENGINEERING_TELEMETRY=Build) Pointers and fixed size buffers may only be used in an unsafe context

Check failure on line 1127 in src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release Mono_DebuggerTests_chrome)

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs#L1127

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1127,22): error CS0214: (NETCORE_ENGINEERING_TELEMETRY=Build) Pointers and fixed size buffers may only be used in an unsafe context

Check failure on line 1127 in src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build browser-wasm linux Release Mono_DebuggerTests_chrome)

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs#L1127

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1127,21): error CS0214: (NETCORE_ENGINEERING_TELEMETRY=Build) Pointers and fixed size buffers may only be used in an unsafe context