Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workload-testing] Misc improvements #99392

Merged
merged 9 commits into from
Mar 8, 2024
Merged

[workload-testing] Misc improvements #99392

merged 9 commits into from
Mar 8, 2024

Conversation

radical
Copy link
Member

@radical radical commented Mar 7, 2024 •
edited
Loading

  • Use PackageDownload instead of PackageReference
    .. to get manifest, and workload pack nugets. The task does not need
    these to be references as it essentially just copies files from the
    restored location to the sdk. But using PackageDownload allows
    packages with PackageType=DotnetPlatform to work too, which is most
    manifest nugets.
  • Add property for output of workload-install command
  • Add support for emitting packageSourceMappings in nuget.config
  • Add PackageSourceNameForBuiltPackages property that defaults to nuget-local

cc @joperezr

radical added 5 commits March 6, 2024 18:54
@radical
[workload-testing] Use PackageDownload instead of PackageReference
f079bfe 
.. to get manifest, and workload pack nugets. The task does not need
these to be references as it essentially just copies files from the
restored location to the sdk. But using `PackageDownload` allows
packages with `PackageType=DotnetPlatform` to work too, which is most
manifest nugets.
@radical
[workload-testing] Add property for output of workload-install command
2a665d4
@radical
Add support for emitting packageSourceMappings in nuget.config, which…
fff35b8 
… is useful when using Central Package Management
@radical
cleanup
d07c3f6
@radical
[workload-testing] Add PackageSourceNameForBuiltPackages property tha…
0ff9c23 
…t defaults to nuget-local
@radical radical added the arch-wasm WebAssembly architecture label Mar 7, 2024
@ghost
Copy link

ghost commented Mar 7, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use PackageDownload instead of PackageReference
    .. to get manifest, and workload pack nugets. The task does not need
    these to be references as it essentially just copies files from the
    restored location to the sdk. But using PackageDownload allows
    packages with PackageType=DotnetPlatform to work too, which is most
    manifest nugets.
  • Add property for output of workload-install command
  • Add support for emitting packageSourceMappings in nuget.config
  • Add PackageSourceNameForBuiltPackages property that defaults to nuget-local
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@ghost ghost assigned radical Mar 7, 2024
@ghost
Copy link

ghost commented Mar 7, 2024

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use PackageDownload instead of PackageReference
    .. to get manifest, and workload pack nugets. The task does not need
    these to be references as it essentially just copies files from the
    restored location to the sdk. But using PackageDownload allows
    packages with PackageType=DotnetPlatform to work too, which is most
    manifest nugets.
  • Add property for output of workload-install command
  • Add support for emitting packageSourceMappings in nuget.config
  • Add PackageSourceNameForBuiltPackages property that defaults to nuget-local
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radical radical mentioned this pull request Mar 7, 2024
Closed
9 tasks
@radical
Extract the nuget.config patch method into a separate task
512f1ab 
`PatchNuGetConfig`

This would be useful in generating similar files for running tests.
@build-analysis build-analysis bot mentioned this pull request Mar 7, 2024
Closed
@radical radical marked this pull request as ready for review March 7, 2024 17:53
@radical radical requested review from maraf, lewing, ilonatommy and akoeplinger and removed request for marek-safar and akoeplinger March 7, 2024 17:53
This was referenced Mar 7, 2024
Closed
Closed
radical and others added 2 commits March 8, 2024 03:43
@radical @ilonatommy
Update src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/…
8d12e97 
…README.md

Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
@radical
address review feedback from @ ilonatommy
ad245c4
@build-analysis build-analysis bot mentioned this pull request Mar 8, 2024
Closed
@radical radical merged commit 782987e into dotnet:main Mar 8, 2024
31 of 34 checks passed
@radical radical deleted the workload-manifest-install branch March 8, 2024 17:40
@radical
Copy link
Member Author

radical commented Mar 8, 2024

@ilonatommy @maraf thanks for the reviews!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @maraf @ilonatommy