Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 7, 2019

The \n will print as it is, not as a new line.

Update: After creating this PR, I've searched for \n in .vb files inside the whole repo and found many results. I noticed that \t was used in some places too instead of vbTab

image

@rpetrusha , Can you confirm that the change is correct before I try to update all the occurrences ?
If that's correct, you can merge this PR until I work to fix all the \n occurrences.

I've also removed an extra ; and will search if there are more occurrences in different files.

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Youssef1313, for addressing these various issues in the Visual Basic code. I'll merge your PR now.

@rpetrusha rpetrusha added this to the September 2019 milestone Sep 9, 2019
@rpetrusha rpetrusha merged commit ba98ee9 into dotnet:master Sep 9, 2019
@Youssef1313 Youssef1313 deleted the patch-3 branch September 9, 2019 15:54
nemrism pushed a commit to nemrism/dotnet-samples that referenced this pull request Sep 20, 2019
* Fixes dotnet#1437 (typo in field name)

* Fixes dotnet#1437 (a few more typos)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants