Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 19, 2018

Above the example, it is said:
"The following example defines a Location class whose constructor has a single string parameter named name.
The expression body definition assigns the argument to the Name property."

Summary

Describe your changes here.

Fixes dotnet/docs#Issue_Number (if available)

Above the example, it is said:
"The following example defines a Location class whose constructor has a single string parameter named name.
The expression body definition assigns the argument to the Name property."
@ghost ghost requested a review from BillWagner as a code owner July 19, 2018 18:48
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and making the fix @johnnyagerard
We appreciate it.

Both versions work, but the change you've made is more clear for this sample. I've reviewed the change, and I'll :shipit: now.

Thanks again for contributing to docs.

@BillWagner BillWagner merged commit de590ba into dotnet:master Jul 20, 2018
@ghost ghost deleted the patch-1 branch July 20, 2018 16:25
@mairaw mairaw assigned ghost Jul 20, 2018
@mairaw mairaw added the 📁 Repo - samples Indicates PRs done in the samples repo. label Jul 20, 2018
karelz pushed a commit to karelz/samples that referenced this pull request Aug 31, 2018
Above the example, it is said:
"The following example defines a Location class whose constructor has a single string parameter named name.
The expression body definition assigns the argument to the Name property."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📁 Repo - samples Indicates PRs done in the samples repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants