Add WinRT Sample #387
Merged
Add WinRT Sample #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
LGTM. @richlander and @diverdan92, do you want to review this PR?
diverdan92
reviewed
Oct 23, 2018
wpf/WPF-WinRT/README.md
Outdated
|
|
||
| This sample shows how to consume the Windows 10 API from .NET Core and .Net Framework projects. | ||
|
|
||
| Windows 10 SDK is required. |
diverdan92
reviewed
Oct 23, 2018
diverdan92
suggested changes
Oct 23, 2018
There was a problem hiding this comment.
Mostly looks good. I would spend more time on the readme.
Mention that this includes samples for both .NET Core and .NET FX. Call out how to get a project from scratch setup. Also, I would update the readme under dotnet/samples/wpf with a pointer to the .NET Core version of this sample.
|
Closing and reopening to begin new WIP check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NetFx and NetCore projects using the Win10 API (no glue assemblies for now)