Introduce using statements #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Dec 31, 2018
There was a problem hiding this comment.
These changes look great @NextTurn
I had a couple small comments, where the code could be a bit more clear by using string interpolation.
Let me know what you think, and I'll merge after the new year.
...ets/csharp/VS_Snippets_CLR/Process_GetProcessesByName2_2/CS/process_getprocessesbyname2_2.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/VS_Snippets_CLR/process_sample/CS/process_sample.cs
Outdated
Show resolved
Hide resolved
|
I also prefer string interpolation. Some expressions are too long, I kept them as they are. |
|
Thanks for your reviews Happy New Year 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C# samples related to
System.Diagnostics.ProcessContributes to dotnet/dotnet-api-docs#1491, dotnet/dotnet-api-docs#1718