Skip to content

Conversation

@janvorli
Copy link
Member

@janvorli janvorli commented Feb 4, 2019

Summary

Extract snippets from the unloadability-howto.md instead of keepiong them inline in the doc.

@janvorli janvorli added the new-content Indicates PRs that contain new articles label Feb 4, 2019
@janvorli janvorli self-assigned this Feb 4, 2019
@janvorli janvorli requested a review from rpetrusha February 4, 2019 12:48
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the code in the dotnet/samples repo, @janvorli. I'll merge this, and we can review the PR with the code from this repo.
There is one caveat: code in the samples repo should be compilable. I apologize for that -- I should have spelled out what code in the samples repo is expected to be. So a 2-line snippet like the one in snippets/core/tutorials/unloading/create_test_assemblyloadcontext.cs should be fully compilable. But we can deal with those issues in the process of reviewing your PR in dotnet/docs or after we've merged.

@rpetrusha rpetrusha merged commit 605c2ee into dotnet:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-content Indicates PRs that contain new articles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants