Move snippet to samples repo and add line highlighting #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Mar 28, 2019
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Overall, this looks great @dksimpson
I had one comment, that includes some of the code beyond this PR, but it would help with presentation.
Once that's done, I'll 
.
Thanks again.
| protected override void OnStart(string[] args) | ||
| { | ||
| eventLog1.WriteEntry("In OnStart"); | ||
| eventLog1.WriteEntry("In OnStart."); |
Member
There was a problem hiding this comment.
This looks like it's formatted badly. Can we standardize on 4 spaces for indentation?
Contributor
Author
There was a problem hiding this comment.
Hi @BillWagner, thanks for your review - I've standardized the spacing in the MyNewService C# and VB files.
added 2 commits
March 28, 2019 09:25
…e-windows-service-app-snippet
Contributor
Author
|
#sign-off |
Contributor
Author
|
This PR is related to #dotnet/docs#11531, which can be merged after this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to .NET refresh work for task 1409933: https://mseng.visualstudio.com/TechnicalContent/_workitems/edit/1409933/
Move C# and VB code samples from article to samples repo and add highlighting: https://docs.microsoft.com/en-us/dotnet/framework/windows-services/walkthrough-creating-a-windows-service-application-in-the-component-designer
See comments in PR #dotnet/docs#11110