From 935070d61109cb0d6d62df7cd0346418eb25b8ce Mon Sep 17 00:00:00 2001 From: Nikola Milosavljevic Date: Mon, 16 Sep 2024 17:49:53 +0000 Subject: [PATCH] Comment-out jobs instead of using variables --- eng/pipelines/templates/stages/vmr-build.yml | 229 +++++++++---------- 1 file changed, 109 insertions(+), 120 deletions(-) diff --git a/eng/pipelines/templates/stages/vmr-build.yml b/eng/pipelines/templates/stages/vmr-build.yml index 546a1ef0b291..b3124c3e5150 100644 --- a/eng/pipelines/templates/stages/vmr-build.yml +++ b/eng/pipelines/templates/stages/vmr-build.yml @@ -28,11 +28,6 @@ parameters: type: boolean default: false -# True when Stage-2 source-only builds are enabled -- name: enableStage2Builds - type: boolean - default: false - # These are not expected to be passed it but rather just object variables reused below - name: pool_Linux type: object @@ -109,45 +104,43 @@ stages: ### Additional jobs for lite/full builds ### - ${{ if in(parameters.scope, 'lite', 'full') }}: - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Online_CurrentSourceBuiltSdk', variables.centOSStreamName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.centOSStreamContainer }} - buildFromArchive: false # 🚫 - buildSourceOnly: true # ✅ - enablePoison: false # 🚫 - excludeOmniSharpTests: true # ✅ - runOnline: true # ✅ - useMonoRuntime: false # 🚫 - withPreviousSDK: false # 🚫 - reuseBuildArtifactsFrom: - - ${{ format('{0}_Online_MsftSdk_x64', variables.centOSStreamName) }} - - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Offline_PreviousSourceBuiltSdk', variables.alpinePreviousName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - artifactsRid: ${{ variables.alpinePreviousX64Rid }} - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.alpinePreviousContainer }} - targetRid: ${{ variables.alpinePreviousX64Rid }} - buildFromArchive: false # 🚫 - buildSourceOnly: true # ✅ - enablePoison: true # ✅ - excludeOmniSharpTests: true # ✅ - runOnline: false # 🚫 - useMonoRuntime: false # 🚫 - withPreviousSDK: true # ✅ + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Online_CurrentSourceBuiltSdk', variables.centOSStreamName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.centOSStreamContainer }} + # buildFromArchive: false # 🚫 + # buildSourceOnly: true # ✅ + # enablePoison: false # 🚫 + # excludeOmniSharpTests: true # ✅ + # runOnline: true # ✅ + # useMonoRuntime: false # 🚫 + # withPreviousSDK: false # 🚫 + # reuseBuildArtifactsFrom: + # - ${{ format('{0}_Online_MsftSdk_x64', variables.centOSStreamName) }} + + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Offline_PreviousSourceBuiltSdk', variables.alpinePreviousName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # artifactsRid: ${{ variables.alpinePreviousX64Rid }} + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.alpinePreviousContainer }} + # targetRid: ${{ variables.alpinePreviousX64Rid }} + # buildFromArchive: false # 🚫 + # buildSourceOnly: true # ✅ + # enablePoison: true # ✅ + # excludeOmniSharpTests: true # ✅ + # runOnline: false # 🚫 + # useMonoRuntime: false # 🚫 + # withPreviousSDK: true # ✅ ### Additional jobs for full build ### - ${{ if in(parameters.scope, 'full') }}: @@ -206,43 +199,41 @@ stages: useMonoRuntime: false # 🚫 withPreviousSDK: false # 🚫 - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Online_PreviousSourceBuiltSdk', variables.centOSStreamName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - artifactsRid: ${{ variables.centOSStreamX64Rid }} - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.centOSStreamContainer }} - buildFromArchive: false # 🚫 - buildSourceOnly: true # ✅ - enablePoison: false # 🚫 - excludeOmniSharpTests: false # 🚫 - runOnline: true # ✅ - useMonoRuntime: false # 🚫 - withPreviousSDK: true # ✅ - - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Offline_PreviousSourceBuiltSdk', variables.centOSStreamName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - artifactsRid: ${{ variables.centOSStreamX64Rid }} - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.centOSStreamContainer }} - buildFromArchive: false # 🚫 - buildSourceOnly: true # ✅ - enablePoison: false # 🚫 - excludeOmniSharpTests: true # ✅ - runOnline: false # 🚫 - useMonoRuntime: false # 🚫 - withPreviousSDK: true # ✅ + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Online_PreviousSourceBuiltSdk', variables.centOSStreamName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # artifactsRid: ${{ variables.centOSStreamX64Rid }} + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.centOSStreamContainer }} + # buildFromArchive: false # 🚫 + # buildSourceOnly: true # ✅ + # enablePoison: false # 🚫 + # excludeOmniSharpTests: false # 🚫 + # runOnline: true # ✅ + # useMonoRuntime: false # 🚫 + # withPreviousSDK: true # ✅ + + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Offline_PreviousSourceBuiltSdk', variables.centOSStreamName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # artifactsRid: ${{ variables.centOSStreamX64Rid }} + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.centOSStreamContainer }} + # buildFromArchive: false # 🚫 + # buildSourceOnly: true # ✅ + # enablePoison: false # 🚫 + # excludeOmniSharpTests: true # ✅ + # runOnline: false # 🚫 + # useMonoRuntime: false # 🚫 + # withPreviousSDK: true # ✅ - template: ../jobs/vmr-build.yml parameters: @@ -312,45 +303,43 @@ stages: useMonoRuntime: false # 🚫 withPreviousSDK: false # 🚫 - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Offline_CurrentSourceBuiltSdk', variables.fedoraName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.fedoraContainer }} - buildFromArchive: false # 🚫 - buildSourceOnly: true # ✅ - enablePoison: false # 🚫 - excludeOmniSharpTests: false # 🚫 - runOnline: false # 🚫 - useMonoRuntime: false # 🚫 - withPreviousSDK: false # 🚫 - reuseBuildArtifactsFrom: - - ${{ format('{0}_Offline_MsftSdk_x64', variables.fedoraName) }} - - - ${{ if parameters.enableStage2Builds }}: - - template: ../jobs/vmr-build.yml - parameters: - # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline - buildName: ${{ format('{0}_Mono_Offline_CurrentSourceBuiltSdk', variables.centOSStreamName) }} - isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} - vmrBranch: ${{ variables.VmrBranch }} - architecture: x64 - pool: ${{ parameters.pool_Linux }} - container: ${{ variables.centOSStreamContainer }} - buildFromArchive: true # ✅ - buildSourceOnly: true # ✅ - enablePoison: false # 🚫 - excludeOmniSharpTests: true # ✅ - runOnline: false # 🚫 - useMonoRuntime: true # ✅ - withPreviousSDK: false # 🚫 - reuseBuildArtifactsFrom: - - ${{ format('{0}_Mono_Offline_MsftSdk_x64', variables.centOSStreamName) }} + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Offline_CurrentSourceBuiltSdk', variables.fedoraName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.fedoraContainer }} + # buildFromArchive: false # 🚫 + # buildSourceOnly: true # ✅ + # enablePoison: false # 🚫 + # excludeOmniSharpTests: false # 🚫 + # runOnline: false # 🚫 + # useMonoRuntime: false # 🚫 + # withPreviousSDK: false # 🚫 + # reuseBuildArtifactsFrom: + # - ${{ format('{0}_Offline_MsftSdk_x64', variables.fedoraName) }} + + # - template: ../jobs/vmr-build.yml + # parameters: + # # Changing the build name requires updating the referenced name in the source-build-sdk-diff-tests.yml pipeline + # buildName: ${{ format('{0}_Mono_Offline_CurrentSourceBuiltSdk', variables.centOSStreamName) }} + # isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }} + # vmrBranch: ${{ variables.VmrBranch }} + # architecture: x64 + # pool: ${{ parameters.pool_Linux }} + # container: ${{ variables.centOSStreamContainer }} + # buildFromArchive: true # ✅ + # buildSourceOnly: true # ✅ + # enablePoison: false # 🚫 + # excludeOmniSharpTests: true # ✅ + # runOnline: false # 🚫 + # useMonoRuntime: true # ✅ + # withPreviousSDK: false # 🚫 + # reuseBuildArtifactsFrom: + # - ${{ format('{0}_Mono_Offline_MsftSdk_x64', variables.centOSStreamName) }} #### VERTICAL BUILD #### - ${{ if not(parameters.isSourceOnlyBuild) }}: