-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core SDK 3.1.200 breaks build which is using GitVersionTask #10878
Comments
I think we in SpecFlow (https://github.com/SpecFlowOSS/SpecFlow/) have a similar issue. As this MSBuild task is used by our users, they are also broken if they use the new SDK. Are we doing something wrong, what worked by accident in the past? Is there something broken? |
One of the things that changed in .200 is how msbuild loads tasks - dotnet/msbuild#4916 |
You could set |
I'll assign this bug to me, but for now it looks like there are two different failure cases:
I'll pursue them on their individual bugs. |
@rainersigwald, just an FYI using assembly load context will break anyone who is using XmlSerializer or DataContractSerializer. It will break anyone who if using RefEmit and referencing types loaded in the ALC. |
experiencing the same issue here. |
What could be the reason that the workaround with On this Ubuntu 16.04 machine it works.
On this Ubuntu 18.04 machine the build still fails.
|
Can you try a |
Well, the workaround with |
@onyxmaster can you elaborate on that, please? |
Sure, thanks for looking into this. Please see the repro. |
@onyxmaster Thanks! This appears to have been fixed in Fody 6.0.4, probably by Fody/Fody@7f4f425. I was able to get your repro working by forcing an updated ref: diff --git a/Independent.csproj b/Independent.csproj
index c915944..294ba7b 100644
--- a/Independent.csproj
+++ b/Independent.csproj
@@ -5,5 +5,6 @@
<ItemGroup>
<PackageReference Include="ModuleInit.Fody" Version="2.1.0" PrivateAssets="all"/>
+ <PackageReference Include="Fody" Version="6.0.4" PrivateAssets="all"/>
</ItemGroup>
</Project> FYI @SimonCropp. |
thats why every fody addin has this explicitly in the readme
https://github.com/Fody/ModuleInit#nuget-installation |
|
|
Tracked by dotnet/msbuild#5202 |
Using GitVersionTask 5.1.2 with CoreWCF builds successfully with .NET Core SDK 3.1.101, but when the SDK was updated by a recent VS update, it broke the build. I have also tried GitVersion 5.1.3 and the latest 5.2.3 with the same result. Reinstalling .NET Core SDK 3.1.101 (as VS updater removes it) and adding a global.json file to specify using that version of the SDK results in the build succeeding again. Here is the error message I get from the build:
The text was updated successfully, but these errors were encountered: