Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TransactionScope MaximumTimeout when API is ready #21101

Open
wli3 opened this issue Sep 17, 2021 · 0 comments
Open

Set TransactionScope MaximumTimeout when API is ready #21101

wli3 opened this issue Sep 17, 2021 · 0 comments
Labels
Area-NetSDK untriaged Request triage from a team member
Milestone
Backlog

Comments

@wli3
Copy link

wli3 commented Sep 17, 2021 •
edited
Loading

We don't really use TransactionScope sematic to the fullest. The download is not atomic, the "commit" action (the right thing is to use atomic operation like File.Move) is missing. At the same time, TransactionScope has a hard code 10 minutes timeout in dotnet core.

dotnet/runtime#59282 is file for a proper API. Once it is done, we should use the feature instead.
@wli3 wli3 added this to the 6.0.2xx milestone Sep 17, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Sep 17, 2021
wli3 pushed a commit to wli3/sdk that referenced this issue Sep 17, 2021
Fix 10 minutes time out of TransactionScope
0493702 
dotnet#21101
This was referenced Sep 17, 2021
Merged
Closed
@wli3 wli3 changed the title Replace TransactionScope Set TransactionScope MaximumTimeout when API is ready Sep 17, 2021
wli3 pushed a commit to wli3/sdk that referenced this issue Sep 17, 2021
Fix 10 minutes time out of TransactionScope
9f91479 
dotnet#21101
wli3 pushed a commit to wli3/sdk that referenced this issue Sep 17, 2021
Fix 10 minutes time out of TransactionScope
b888bd0 
dotnet#21101
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.2xx, 7.0.1xx Jan 5, 2022
@marcpopMSFT marcpopMSFT modified the milestones: 7.0.1xx, Backlog Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@wli3 @marcpopMSFT