Skip to content

Conversation

@richlander
Copy link
Member

This multi-line warning bugs me. I'd like it to be single line.

  • Not sure if the localized files need to be updated. I didn't do that, but can.
  • The link (same as old one) isn't that helpful. We should have a doc on using previews. Global.json is one part of using previews.

@livarcocc livarcocc added this to the 2.1.3xx milestone Apr 30, 2018
@livarcocc
Copy link
Contributor

cc @KathleenDollard to review.

I will take it to shiproom when @KathleenDollard reviews it.

@KathleenDollard
Copy link

Let's fix this according to Rich's suggestion.

@livarcocc
Copy link
Contributor

Actually, at this point, I think we should take this for 2.1.4xx. @richlander , I will take your commit, put it in my own branch, fix the test failures and re-target it to 2.1.4xx.

@wli3
Copy link

wli3 commented May 14, 2018

seems miss xlf update. You need to run ./build.cmd -p:UpdateXlfOnBuild=true and check in the result

@nguerrera
Copy link
Contributor

Replaced by #2286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants