Add ability to use test config file to list tests to skip #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests? |
wli3
reviewed
May 13, 2019
| return ret; | ||
| } | ||
|
|
||
| public static List<string> GetXunitArgsFromTestConfig(string testConfigFile) |
|
is test config a standard format? could you give me the link to the schema? |
Member
Author
|
@wli3 This is just a format I came up with. It's not part of the product, it lets us specify which of our tests should be skipped, and all of our tests are Xunit. It doesn't apply to |
|
I see, it is only in tests, not the product |
wli3
approved these changes
May 14, 2019
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
* Update dependencies from https://github.com/dotnet/arcade build 20191017.8 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19517.8 Dependency coherency updates - Microsoft.NET.Sdk.WindowsDesktop - 5.0.0-alpha1.19462.16 (parent: Microsoft.WindowsDesktop.App) * Update dependencies from https://github.com/dotnet/arcade build 20191018.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19518.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing a
-testConfigFileparameter when running tests. This allows individual tests to be skipped without having to modify the test source code. This will be helpful to allow tests to be run on other repos, such as with dotnet/installer#1454.The test config file looks like this
The
IssueandReasonattributes aren't currently used, they are merely informational to help us keep such a list up-to-date.