Add APICompat support for checking generic constraints #40230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
ericstj
force-pushed
the
validateGenericConstraints
branch
from
70ab8fa to
17c3dbb
Compare
ericstj
commented
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Outdated
Show resolved
Hide resolved
DocComments use ``n to refer to the generic argument by index. �Use this in our diagnostics to refer to the constraint on a type. Also fix some comments.
|
Here's the diff we need in dotnet/runtime to fix issues found with this rule: ericstj/runtime@b2220ea |
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 17, 2024
...tibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeGenericConstraints.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39659
Still pending running this against dotnet/runtime for validation.