Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILMerge version not found while building VMR main #3472

Closed
tmds opened this issue May 23, 2023 · 11 comments
Closed

ILMerge version not found while building VMR main #3472

tmds opened this issue May 23, 2023 · 11 comments
Assignees
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@tmds
Copy link
Member

tmds commented May 23, 2023

I'm building vmr main (at 2e71a23ab11c8480aa28ad959656dceb4020760c).

The build fails with:

  /home/tmds/repos/dotnet/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj : error NU1102: Unable to find package ILMerge with version (>= 3.0.41) [/home/tmds/repos/dotnet/src/nuget-client/build/restorehelper.targets]
  /home/tmds/repos/dotnet/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj : error NU1102:   - Found 1 version(s) in prebuilt [ Nearest version: 3.0.21 ] [/home/tmds/repos/dotnet/src/nuget-client/build/restorehelper.targets]
  /home/tmds/repos/dotnet/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj : error NU1102:   - Found 0 version(s) in source-built [/home/tmds/repos/dotnet/src/nuget-client/build/restorehelper.targets]
  /home/tmds/repos/dotnet/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj : error NU1102:   - Found 0 version(s) in previously-source-built [/home/tmds/repos/dotnet/src/nuget-client/build/restorehelper.targets]
  /home/tmds/repos/dotnet/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj : error NU1102:   - Found 0 version(s) in reference-packages [/home/tmds/repos/dotnet/src/nuget-client/build/restorehelper.targets]

Is it expected for the main branch to not be buildable? And what can I do about it?

cc @MichaelSimons @omajid

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

This prebuilt comes from NuGet.Client and is tracked with NuGet/Home#12604. The prebuilts tarball was update in dotnet/installer#16448 to include this but it looks like an updated dependency version flowed in.

@NikolaMilosavljevic - If you are not close to a solution, could you update the prebuilts tarball? TIA.

@NikolaMilosavljevic
Copy link
Member

This prebuilt comes from NuGet.Client and is tracked with NuGet/Home#12604. The prebuilts tarball was update in dotnet/installer#16448 to include this but it looks like an updated dependency version flowed in.

@NikolaMilosavljevic - If you are not close to a solution, could you update the prebuilts tarball? TIA.

I'll update the tarball, to unblock the VMR build.

@tmds
Copy link
Member Author

tmds commented May 23, 2023

How do you obtain the ILMerge package? and create a new tarball?

@tmds
Copy link
Member Author

tmds commented May 23, 2023

I ran the ./build.sh command without the --online argument. Would adding the argument have made a difference?

@NikolaMilosavljevic
Copy link
Member

I ran the ./build.sh command without the --online argument. Would adding the argument have made a difference?

Yes, --online would have enabled the build to obtain packages from nuget.org and show them as warnings in your build, instead of errors.

@MichaelSimons
Copy link
Member

I ran the ./build.sh command without the --online argument. Would adding the argument have made a difference?

Yes, the build will pass with an online build. You can also retrieve the package from the online build to update the tarball.

@tmds
Copy link
Member Author

tmds commented May 23, 2023

Is it the expectation that the main branch is (occasionally) not working without the --online flag?
Or is the expected workflow to update the prebuilts (in sync) as part of updating the main branch?

@MichaelSimons
Copy link
Member

Is it the expectation that the main branch is (occasionally) not working without the --online flag?

Yes, until we complete the work to enable prebuilt detection at the repo level.

@tmds
Copy link
Member Author

tmds commented May 23, 2023

Thanks for clarifying.

@MichaelSimons MichaelSimons self-assigned this May 25, 2023
@MichaelSimons MichaelSimons added area-prebuilts Reducing the number of prebuilt packages in the tarball and removed untriaged labels May 25, 2023
@MichaelSimons MichaelSimons moved this to In Progress in .NET Source Build May 25, 2023
@MichaelSimons
Copy link
Member

This was fixed by NuGet.Client in NuGet/NuGet.Client#5178. We added a patch until the fix flows in.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
Archived in project
Development

No branches or pull requests

3 participants