This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
remove tyeDir from PurgeHostAndWaitForGivenReplicasToStop #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
I'm not sure how this can be a breaking change, we don't have any APIs for public consumption 😆 yet. This is just test code. My guess is that this changed when @davidfowl was doing some cleanup. |
rynowak
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is a breaking change.
i cant tell if this is a bug in that it isnt used. or it is future proofing for when it will be needed?