From f339387d270a6b4238690b06d4beaa77fa51c183 Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Thu, 10 Aug 2023 17:08:01 +0200
Subject: [PATCH] Remove System.Reflection.DispatchProxy reference (#5230)

* Remove System.Reflection.DispatchProxy reference

System.Reflection.DispatchProxy has been absorbed into the shared framework since early .NETCoreApp days. The package hasn't been shipping for years now and shouldn't be referenced anymore.

* Update Versions.props

* Remove unused arcade properties (#5231)

* Remove unused arcade properties

* Update Version.Details.xml
---
 eng/Version.Details.xml                                   | 8 --------
 eng/Versions.props                                        | 4 ----
 .../src/System.ServiceModel.Primitives.csproj             | 3 +--
 3 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index e3ed627f456..a62898fba2e 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -8,14 +8,6 @@
       <Uri>https://github.com/dotnet/arcade</Uri>
       <Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.DotNet.SignTool" Version="8.0.0-beta.23409.5">
-      <Uri>https://github.com/dotnet/arcade</Uri>
-      <Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
-    </Dependency>
-    <Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="8.0.0-beta.23409.5">
-      <Uri>https://github.com/dotnet/arcade</Uri>
-      <Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
-    </Dependency>
     <Dependency Name="Microsoft.DotNet.GenFacades" Version="8.0.0-beta.23409.5">
       <Uri>https://github.com/dotnet/arcade</Uri>
       <Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
diff --git a/eng/Versions.props b/eng/Versions.props
index d5e70d755af..62a9ee304bc 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -16,15 +16,11 @@
   </PropertyGroup>
   <!-- Arcade dependencies -->
   <PropertyGroup>
-    <MicrosoftDotNetArcadeSdkPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetArcadeSdkPackageVersion>
-    <MicrosoftDotNetHelixSdkPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetHelixSdkPackageVersion>
     <MicrosoftDotNetGenFacadesPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetGenFacadesPackageVersion>
     <MicrosoftDotNetXUnitExtensionsPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetXUnitExtensionsPackageVersion>
-    <MicrosoftDotNetSignToolVersion>8.0.0-beta.23409.5</MicrosoftDotNetSignToolVersion>
   </PropertyGroup>
   <!-- CoreFx dependencies -->
   <PropertyGroup>
-    <SystemReflectionDispatchProxyPackageVersion>4.7.1</SystemReflectionDispatchProxyPackageVersion>
     <SystemSecurityCryptographyXmlPackageVersion>6.0.1</SystemSecurityCryptographyXmlPackageVersion>
     <MicrosoftExtensionsObjectPoolVersion>6.0.16</MicrosoftExtensionsObjectPoolVersion>
   </PropertyGroup>
diff --git a/src/System.ServiceModel.Primitives/src/System.ServiceModel.Primitives.csproj b/src/System.ServiceModel.Primitives/src/System.ServiceModel.Primitives.csproj
index c4aff9bba2a..ea56407ec80 100644
--- a/src/System.ServiceModel.Primitives/src/System.ServiceModel.Primitives.csproj
+++ b/src/System.ServiceModel.Primitives/src/System.ServiceModel.Primitives.csproj
@@ -8,7 +8,7 @@
     <IsPackable>true</IsPackable>
     <!-- Workaround for https://github.com/NuGet/NuGet.Client/pull/3016 -->
     <NoWarn>$(NoWarn);NU5131</NoWarn>
-    <TargetFrameworks>net6.0</TargetFrameworks>
+    <TargetFramework>net6.0</TargetFramework>
     <IsShipping>$(Ship_WcfPackages)</IsShipping>
     <PackageDescription>Provides the common types used by all of the WCF libraries.</PackageDescription>
     <IsPartialFacadeAssembly>true</IsPartialFacadeAssembly>
@@ -23,7 +23,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="System.Reflection.DispatchProxy" Version="$(SystemReflectionDispatchProxyPackageVersion)" />
     <PackageReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlPackageVersion)" />
     <PackageReference Include="Microsoft.Extensions.ObjectPool" Version="$(MicrosoftExtensionsObjectPoolVersion)" />
   </ItemGroup>