[release/8.0] Migrate to 1ES Pipeline Template #4258
Conversation
| timeoutInMinutes: ${{ parameters.timeoutInMinutes }} | ||
| pool: | ||
| # Use a hosted pool when possible. | ||
| ${{ if eq(variables['System.TeamProject'], 'public') }}: |
There was a problem hiding this comment.
Since we have internal WD PRs, the PR template will probably get used on internal projects.
| name: NetCore1ESPool-Internal | ||
| demands: ImageOverride -equals windows.vs2022preview.amd64 | ||
|
|
||
| - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: |
There was a problem hiding this comment.
@mmitche double checking, do conditions specifying build.reason is pull request need to remain for the non -PR.yml or can these be removed?
There was a problem hiding this comment.
They can be removed, but we need to create a PR pipeline for WD on the internal project before check-in, since the official pipeline will no longer be used for PRs.
There was a problem hiding this comment.
Is there guidance on how to do this correctly and does the same need to be done for winforms/wpf?
There was a problem hiding this comment.
Same needs to be done for wpf/winforms (since they take internal PRs). For each of these types of conditionals, you can say the following
- The pr pipeline can assume PR == true. Often this has little do with actual pull requests, and more to do with what testing is run, or whether real signing should be attempted, for instance.
- The PR pipeline should not assume public vs. internal.
Does that answer your question?
There was a problem hiding this comment.
Apologies, I wasn't specific, I mean guidance in terms of creating the PR pipeline on the internal project. Specifically any preferred naming or space to update that tracks the new pipelines needed to be created (we can also chat offline that may be better 😄 )
2 participants
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2408677&view=results
Steps:
Note: no merge until May servicing opens