Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabPage tests and cleanup code #1482

Merged
4 commits merged into from
Jul 29, 2019
Merged

Add TabPage tests and cleanup code #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a9da75
Add TabPage tests
hughbe Jul 22, 2019
6806791
Don't invlaidate when setting TabPage.UseVisualStyleBackColor to the …
hughbe Jul 22, 2019
4f1f7b9
Forward event args from OnLocationChanged to OnMove
hughbe Jul 22, 2019
2b466ba
Cleanup TabPage
hughbe Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/SR.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5753,10 +5753,10 @@ Stack trace where the illegal operation occurred was:
<data name="TabControlSelectingEventDescr" xml:space="preserve">
<value>Occurs when a tab page is being selected. </value>
</data>
<data name="TABCONTROLTabPageNotOnTabControl" xml:space="preserve">
<data name="TabControlTabPageNotOnTabControl" xml:space="preserve">
<value>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</value>
</data>
<data name="TABCONTROLTabPageOnTabPage" xml:space="preserve">
<data name="TabControlTabPageOnTabPage" xml:space="preserve">
<value>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</value>
</data>
<data name="TabControlTabsDescr" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Trasování zásobníku, kde došlo k neplatné operaci:
<target state="translated">Funkce není v tomto operačním systému podporována.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">Objekt TabPage nelze přidat k objektu {0}. Objekt TabPages lze přidat pouze k ovládacímu prvku TabControls.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">Objekt TabPage nelze přidat k jinému ovládacímu prvku TabPage. Objekt TabPages lze přidat pouze k ovládacímu prvku TabControls.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stapelüberwachung, in der der unzulässige Vorgang auftrat:
<target state="translated">Das Feature wird bei diesem Betriebssystem nicht unterstützt.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage kann nicht zu einem {0} hinzugefügt werden. TabPages können nur zu TabControls hinzugefügt werden.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage kann nicht zu einer anderen TabPage hinzugefügt werden. TabPages können nur zu TabControls hinzugefügt werden.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ El seguimiento de la pila donde tuvo lugar la operación no válida fue:
<target state="translated">Este sistema operativo no admite esta característica.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">No se puede agregar TabPage a '{0}'. Sólo se pueden agregar TabPages a TabControls.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">No se puede agregar una TabPage a otra TabPage. Sólo se pueden agregar TabPages a TabControls.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Cette opération non conforme s'est produite sur la trace de la pile :
<target state="translated">Fonctionnalité non prise en charge par ce système d'exploitation.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">Un TabPage ne peut pas être ajouté à un '{0}'. Les TabPages ne peuvent être ajoutés qu'aux TabControls.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">Un TabPage ne peut pas être ajouté à un autre TabPage. Les TabPages ne peuvent être ajoutés qu'aux TabControls.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Traccia dello stack da cui si è verificata l'operazione non valida:
<target state="translated">Funzionalità non supportata in questo sistema operativo.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">Impossibile aggiungere un oggetto TabPage a '{0}'. Gli oggetti TabPage possono essere aggiunti solo a una classe TabControl.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">Impossibile aggiungere un oggetto TabPage a un altro oggetto TabPage. Gli oggetti TabPage possono essere aggiunti solo a una classe TabControl.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stack trace where the illegal operation occurred was:
<target state="translated">機能はこのオペレーティング システムでサポートされていません。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage を '{0}' に追加できません。 TabPages は TabControls にのみ追加できます。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage を他の TabPage に追加できません。 TabPages は、TabControls にのみ追加できます。</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stack trace where the illegal operation occurred was:
<target state="translated">이 운영 시스템에서 지원되지 않는 기능입니다.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage를 '{0}'에 추가할 수 없습니다. TabPages는 TabControls에만 추가할 수 있습니다.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage를 다른 TabPage에 추가할 수 없습니다. TabPages는 TabControls에만 추가할 수 있습니다.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stos śledzenia, w którym wystąpiła zabroniona operacja:
<target state="translated">Funkcja nie jest obsługiwana w tym systemie operacyjnym.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">Nie można dodać elementu TabPage do elementu „{0}”. Elementy TabPage mogą być dodawane tylko do elementów TabControl.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">Nie można dodać elementu TabPage do innego elementu TabPage. Elementy TabPage mogą być dodawane tylko do elementów TabControl.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Rastreamento de pilha em que a operação ilegal ocorreu:
<target state="translated">Não há suporte para o recurso com este sistema operacional.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage não pode ser adicionado a '{0}'. TabPages só podem ser adicionados a TabControls.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage não pode ser adicionado a outro TabPage. TabPages só podem ser adicionados a TabControls.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9512,12 +9512,12 @@ Stack trace where the illegal operation occurred was:
<target state="translated">Функция не поддерживается в данной ОС.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage нельзя добавить к '{0}'. TabPages можно добавлять только к TabControls.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">TabPage нельзя добавить к другой TabPage. TabPages можно добавлять только к TabControls.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Geçersiz işlemin gerçekleştiği yığın izi:
<target state="translated">Özellik bu işletim sistemiyle desteklenmiyor.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">'{0}' öğesine TabPage eklenemez. TabPage'ler yalnızca TabControl'lere eklenebilir.</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">Bir TabPage başka bir TabPage'e eklenemez. TabPage'ler yalnızca TabControl'lere eklenebilir.</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stack trace where the illegal operation occurred was:
<target state="translated">此操作系统不支持该功能。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">无法将 TabPage 添加到“{0}”。 只能将 TabPages 添加到 TabControls。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">无法将 TabPage 添加到其他 TabPage。 TabPages 只能添加到 TabControls。</target>
<note />
Expand Down
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/xlf/SR.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9511,12 +9511,12 @@ Stack trace where the illegal operation occurred was:
<target state="translated">此作業系統不支援這項功能。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageNotOnTabControl">
<trans-unit id="TabControlTabPageNotOnTabControl">
<source>TabPage cannot be added to a '{0}'. TabPages can only be added to TabControls.</source>
<target state="translated">無法將 TabPage 加入 '{0}'。TabPages 只能加入 TabControls。</target>
<note />
</trans-unit>
<trans-unit id="TABCONTROLTabPageOnTabPage">
<trans-unit id="TabControlTabPageOnTabPage">
<source>TabPage cannot be added to another TabPage. TabPages can only be added to TabControls.</source>
<target state="translated">無法將 TabPage 加入其他 TabPage。TabPages 只能加入 TabControls。</target>
<note />
Expand Down
3 changes: 1 addition & 2 deletions src/System.Windows.Forms/src/System/Windows/Forms/Control.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8128,8 +8128,7 @@ internal virtual void OnInvokedSetScrollPosition(object sender, EventArgs e)
[EditorBrowsable(EditorBrowsableState.Advanced)]
protected virtual void OnLocationChanged(EventArgs e)
{
OnMove(EventArgs.Empty);

OnMove(e);
hughbe marked this conversation as resolved.
Show resolved Hide resolved
if (Events[EventLocation] is EventHandler eh)
{
eh(this, e);
Expand Down
Loading