diff --git a/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.props b/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.props index 43eb0affa6a..5f9e5fb870a 100644 --- a/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.props +++ b/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.props @@ -1,6 +1,6 @@ - $(MicrosoftNETCoreAppVersion) + $(MicrosoftNETCoreAppVersion) diff --git a/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets b/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets index 065527bdd93..288ba4bcc15 100644 --- a/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets +++ b/eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets @@ -16,6 +16,13 @@ Condition="'$(MicrosoftNETCoreAppVersion)'!='' And '$(NoTargets)'!='true' And $(TargetFramework.StartsWith('netcoreapp3.')) And '$(MSBuildProjectExtension)'!='.vcxproj' And '$(WpfTest)'!='true'"> $(MicrosoftNETCoreAppVersion) + + + diff --git a/eng/WpfArcadeSdk/tools/SdkReferences.targets b/eng/WpfArcadeSdk/tools/SdkReferences.targets index 0481c0d8990..6029219a951 100644 --- a/eng/WpfArcadeSdk/tools/SdkReferences.targets +++ b/eng/WpfArcadeSdk/tools/SdkReferences.targets @@ -64,23 +64,25 @@ + AfterTargets="ResolveTargetingPacks" + Returns="@(Reference)" + Condition="'$(PkgMicrosoft_NETCore_App)'=='' And '@(NetCoreReference)'!='' and '@(Reference)' != ''"> <_netCoreAppSdkReference Remove="@(_netCoreAppSdkReference)" /> - <_netCoreAppSdkReference Include="@(ReferencePath)" - Condition="'%(ReferencePath.NuGetPackageId)'=='Microsoft.NETCore.App.Ref'" /> + <_netCoreAppSdkReference Include="@(Reference)" + Condition="'%(Reference.NuGetPackageId)'=='Microsoft.NETCore.App.Ref'"> + %(Reference.Identity) + - + @@ -94,7 +96,7 @@ - + @@ -115,23 +117,25 @@ + AfterTargets="ResolveTargetingPacks" + Returns="@(Reference)" + Condition="'$(PkgMicrosoft_WindowsDesktop_App)'=='' And '@(WindowsDesktopReference)'!='' and '@(Reference)' != ''"> <_windowsDesktopAppSdkReference Remove="@(_windowsDesktopAppSdkReference)" /> - <_windowsDesktopAppSdkReference Include="@(ReferencePath)" - Condition="'%(ReferencePath.NuGetPackageId)'=='Microsoft.WindowsDesktop.App.Ref'" /> + <_windowsDesktopAppSdkReference Include="@(Reference)" + Condition="'%(Reference.NuGetPackageId)'=='Microsoft.WindowsDesktop.App.Ref'"> + %(Reference.Identity) + - + @@ -145,7 +149,7 @@ - + diff --git a/eng/WpfArcadeSdk/tools/Wpf.Cpp.props b/eng/WpfArcadeSdk/tools/Wpf.Cpp.props index 296bebe9c1e..8df61064b6b 100644 --- a/eng/WpfArcadeSdk/tools/Wpf.Cpp.props +++ b/eng/WpfArcadeSdk/tools/Wpf.Cpp.props @@ -89,11 +89,20 @@ - true + + - 0.0.0.4 - $(RepoRoot).tools\native\bin\msvcurt-c1xx\$(MsvcurtC1xxVersion)\$(Architecture)\ - $(MsvcurtC1xxToolsPath)msvcurt$(LibSuffix)_netcore.lib + + + diff --git a/eng/WpfArcadeSdk/tools/Wpf.Cpp.targets b/eng/WpfArcadeSdk/tools/Wpf.Cpp.targets index 537f71fc07f..23aa8acef95 100644 --- a/eng/WpfArcadeSdk/tools/Wpf.Cpp.targets +++ b/eng/WpfArcadeSdk/tools/Wpf.Cpp.targets @@ -5,6 +5,10 @@ + + diff --git a/global.json b/global.json index c271d8179c8..f39c3909961 100644 --- a/global.json +++ b/global.json @@ -1,18 +1,17 @@ { "tools": { - "dotnet": "3.0.100-preview-010024", + "dotnet": "3.0.100-preview5-011568", "vs": { - "version": "16.0" + "version": "16.1" } }, "sdk": { - "version": "3.0.100-preview-010024" + "version": "3.0.100-preview5-011568" }, "msbuild-sdks": { "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19252.2" }, "native-tools": { - "strawberry-perl": "5.28.1.1-1", - "msvcurt-c1xx": "0.0.0.4" + "strawberry-perl": "5.28.1.1-1" } } diff --git a/src/Microsoft.DotNet.Wpf/test/DRT/DrtXaml/DrtXaml/XamlTestFrameWork/TestFinder.cs b/src/Microsoft.DotNet.Wpf/test/DRT/DrtXaml/DrtXaml/XamlTestFrameWork/TestFinder.cs index 1647e4e2975..64b3c2d3e1a 100644 --- a/src/Microsoft.DotNet.Wpf/test/DRT/DrtXaml/DrtXaml/XamlTestFrameWork/TestFinder.cs +++ b/src/Microsoft.DotNet.Wpf/test/DRT/DrtXaml/DrtXaml/XamlTestFrameWork/TestFinder.cs @@ -189,17 +189,25 @@ private static TestKnownFailureAttribute GetTestKnownFailureAttribute(FieldInfo public static bool IsATestType(Type type) { - if (!type.GetCustomAttributes(typeof(TestClassAttribute), false).Any()) + try { - return false; - } + if (!type.GetCustomAttributes(typeof(TestClassAttribute), false).Any()) + { + return false; + } + + if (type.GetCustomAttributes(typeof(TestDisabledAttribute), false).Any()) + { + return false; + } - if (type.GetCustomAttributes(typeof(TestDisabledAttribute), false).Any()) + return true; + } + catch (TypeLoadException e) when (e.TypeName == "System.Runtime.CompilerServices.SuppressMergeCheckAttribute") { + // Temporary workaround for missing type in System.Runtime return false; } - - return true; } public static bool IsTestMethod(MethodInfo method)