Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native to 0.76.2 #2395

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

puckey
Copy link
Collaborator

@puckey puckey commented Nov 7, 2024

@puckey puckey requested a review from dcvz as a code owner November 7, 2024 13:23
@lovegaoshi
Copy link
Contributor

pls note #2370 breaks on rn <0.76.1

@smfunder
Copy link

I came here to see what would be the progress for this PR to be merged? Would it fully work with RN 0.76.1 is there any help I can provide to try it out?

@puckey puckey changed the title Update React Native to 0.76.1 Update React Native to 0.76.2 Nov 18, 2024
@puckey
Copy link
Collaborator Author

puckey commented Nov 18, 2024

I updated the example app to 0.76.2, which should have fixed the remaining timer issues through facebook/react-native@ee7b4e2. @smfunder would you like to verify?

@smfunder
Copy link

@puckey what would be the best way to try it out? Should I clone the library on this PR's branch and then replace my node_modules/react-native-track-player folder with the content of it?

@lovegaoshi
Copy link
Contributor

u should clone and start testing the example app.

if ur absolutely sure to test in ur own app, do note newarch breaks/bugs many libs right now, so if it doesnt work u shouldnt comment on this PR but the respective libs.

u should first make sure ur project uses RN 0.76.2. then for RNTP instead of a version, use this PR's SHA. for example https://github.com/lovegaoshi/azusa-player-mobile/blob/e3ce4f61806075ce5d6458748b570e9733c7fc2a/package.json#L113. but use this PR's SHA instead

@smfunder
Copy link

thank you @lovegaoshi I will try it asap and get back to you here!

@mrevanzak
Copy link

typescript keep yelling if i use this branch. any idea why? but its work tho

@puckey
Copy link
Collaborator Author

puckey commented Nov 28, 2024

typescript keep yelling if i use this branch. any idea why? but its work tho

What error are you seeing?

@mrevanzak
Copy link

typescript keep yelling if i use this branch. any idea why? but its work tho

What error are you seeing?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants