Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor progressiveFetch into tools.js for reuse by other pages #1

Merged

Conversation

ickk
Copy link

@ickk ickk commented Apr 20, 2022

I see your point about iterative development being a pain if you needed to rerun the generate_wasm_examples.sh script every time. I still think that long-term we should try to move in that direction, when we have better tooling or when the design is more settled; needing to pass in the function to init really sucks, but I agree it is probably the best option we have right now.

This is a compromise; I think keeping progressiveFetch factored out makes it tidier (hides the polyfill junk), easier to read/reason about, and will allow us to use similar functionality else-where without duplicating code too heavily (This will be good for blog posts/release notes/et c.).

other small changes:

  • had to remove some of your comments in the generate script because they broke the escaped Returns.
  • shortened comments in general. If someone wants to know what's going on, one link to your PR should be enough to get them up to speed.
  • put template's comment inside Tera/Zola comment syntax so it won't be rendered

ickk added 2 commits April 20, 2022 21:45
shorten comments
…llow reuse

shorten name of trackLoadingProgressFetch to loadingBarFetch
@doup doup merged commit d3c15ec into doup:feature/improve-example-loading-feedback Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants