factor progressiveFetch into tools.js for reuse by other pages #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see your point about iterative development being a pain if you needed to rerun the
generate_wasm_examples.sh
script every time. I still think that long-term we should try to move in that direction, when we have better tooling or when the design is more settled; needing to pass in the function to init really sucks, but I agree it is probably the best option we have right now.This is a compromise; I think keeping
progressiveFetch
factored out makes it tidier (hides the polyfill junk), easier to read/reason about, and will allow us to use similar functionality else-where without duplicating code too heavily (This will be good for blog posts/release notes/et c.).other small changes: