Skip to content

Conversation

@jeffgran-dox
Copy link

@jeffgran-dox jeffgran-dox commented May 22, 2025

@jeffgran-dox jeffgran-dox marked this pull request as ready for review May 22, 2025 23:08
@jeffgran-dox jeffgran-dox requested review from a team as code owners May 22, 2025 23:08
@jeffgran-dox
Copy link
Author

doxbot codereview

orbs:
ci-utils: doximity/ci-utils@2
browser-tools: circleci/browser-tools@1.5
gem: doximity/gem-publisher@0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ultimately an organizational failure because the wiki docs failed you here. Granted, two of the wiki pages you linked are archived and the one that isn't is stale, but we should also update these pages to be correct.

We don't actually maintain doximity/gem-publisher anymore and it shouldn't be used. https://github.com/doximity/circle-ci-orbs/pull/121

The complication with public/rubygems releases is always going to be the 2FA. Rather than deal with a CI job that will always fail, we have a womm runlist to enable it to be done locally: https://github.com/doximity/works-on-my-machine/blob/master/runlists/open-source-gem-release.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't intend to check this in?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yeah that was an accident, thanks

@jeffgran-dox jeffgran-dox changed the title Add gem publisher Fixup gem for publishing May 27, 2025
@jeffgran-dox jeffgran-dox merged commit 8f274ab into master May 27, 2025
5 checks passed
@jeffgran-dox jeffgran-dox deleted the jg/publisher branch May 27, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants