-
Notifications
You must be signed in to change notification settings - Fork 0
Fixup gem for publishing #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d626df9 to
1b086dc
Compare
|
doxbot codereview |
.circleci/config.yml
Outdated
| orbs: | ||
| ci-utils: doximity/ci-utils@2 | ||
| browser-tools: circleci/browser-tools@1.5 | ||
| gem: doximity/gem-publisher@0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ultimately an organizational failure because the wiki docs failed you here. Granted, two of the wiki pages you linked are archived and the one that isn't is stale, but we should also update these pages to be correct.
We don't actually maintain doximity/gem-publisher anymore and it shouldn't be used. https://github.com/doximity/circle-ci-orbs/pull/121
The complication with public/rubygems releases is always going to be the 2FA. Rather than deal with a CI job that will always fail, we have a womm runlist to enable it to be done locally: https://github.com/doximity/works-on-my-machine/blob/master/runlists/open-source-gem-release.yml
attachinary-dox-1.3.1.pre.gem
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably don't intend to check this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, yeah that was an accident, thanks
8e5841b to
20f5c10
Compare
Published prerelease here: https://rubygems.org/gems/attachinary-dox and tested here: https://github.com/doximity/foundation/pull/816/files#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55fR96