From c98ba69216c0f6cc97d10518a7c493c0fc5d0d12 Mon Sep 17 00:00:00 2001 From: Deepika Pandhi Date: Sat, 4 May 2019 08:15:27 -0700 Subject: [PATCH] anged email address for commit & impleted review updates for #4187 --- cmd/minikube/cmd/start.go | 4 +--- pkg/minikube/bootstrapper/kubeadm/kubeadm.go | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 2ad5ab70acc3..33f7259fc588 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -258,7 +258,7 @@ func showKubectlConnectInfo(kubeconfig *pkgutil.KubeConfigSetup) { if kubeconfig.KeepContext { console.OutStyle("kubectl", "To connect to this cluster, use: kubectl --context=%s", kubeconfig.ClusterName) } else { - console.OutStyle("kubectl", "Done! kubectl is now configured to use %q", cfg.GetMachineName()) + console.OutStyle("ready", "Done! kubectl is now configured to use %q", cfg.GetMachineName()) } _, err := exec.LookPath("kubectl") if err != nil { @@ -590,7 +590,6 @@ func bootstrapCluster(bs bootstrapper.Bootstrapper, r cruntime.Manager, runner b func validateCluster(bs bootstrapper.Bootstrapper, r cruntime.Manager, runner bootstrapper.CommandRunner, ip string, apiserverPort int) { k8sStat := func() (err error) { st, err := bs.GetKubeletStatus() - console.Out(".") if err != nil || st != state.Running.String() { return &pkgutil.RetriableError{Err: fmt.Errorf("kubelet unhealthy: %v: %s", err, st)} } @@ -602,7 +601,6 @@ func validateCluster(bs bootstrapper.Bootstrapper, r cruntime.Manager, runner bo } aStat := func() (err error) { st, err := bs.GetAPIServerStatus(net.ParseIP(ip), apiserverPort) - console.Out(".") if err != nil || st != state.Running.String() { return &pkgutil.RetriableError{Err: fmt.Errorf("apiserver status=%s err=%v", st, err)} } diff --git a/pkg/minikube/bootstrapper/kubeadm/kubeadm.go b/pkg/minikube/bootstrapper/kubeadm/kubeadm.go index 5c5635fa37c7..e136c91ea33d 100644 --- a/pkg/minikube/bootstrapper/kubeadm/kubeadm.go +++ b/pkg/minikube/bootstrapper/kubeadm/kubeadm.go @@ -217,7 +217,7 @@ func (k *Bootstrapper) StartCluster(k8s config.KubernetesConfig) error { return errors.Wrap(err, "wait") } - console.OutStyle("permissions", "Configuring cluster permissions ...") + glog.Infof("Configuring cluster permissions ...") if err := util.RetryAfter(100, elevateKubeSystemPrivileges, time.Millisecond*500); err != nil { return errors.Wrap(err, "timed out waiting to elevate kube-system RBAC privileges") }