Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1699] make tables full width #1010

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 28, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1699

What I did

  • Make tables full width; the ticket mentions removing the background from the table but that impacts our JS-less scroll indicators. Making the table full width resolves the tickets issue and arguably looks better.
Screenshot 2024-01-29 at 9 23 49 am

How to test

  • See storybook

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jan 28, 2024
Copy link

netlify bot commented Jan 28, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit d0f042a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65b6d7f7bd927f00085b4ca2

Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree - this look better.

Copy link

cypress bot commented Jan 28, 2024

Passing run #1181 ↗︎

0 116 0 0 Flakiness 0

Details:

style(@dpc-sdp/ripple-ui-core): make tables full width
Project: ripple-framework Commit: d0f042a38e
Status: Passed Duration: 06:01 💡
Started: Jan 28, 2024 10:39 PM Ended: Jan 28, 2024 10:45 PM

Review all test suite changes for PR #1010 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jan 28, 2024
Merged via the queue into develop with commit e52f548 Jan 28, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/R20-1699-table-feedback branch January 28, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants